Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve test case names #198

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jun 26, 2023

Closes #194

@rootulp rootulp self-assigned this Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #198 (395283d) into master (9df814c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   81.36%   81.36%           
=======================================
  Files           7        7           
  Lines         526      526           
=======================================
  Hits          428      428           
  Misses         58       58           
  Partials       40       40           

Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rootulp rootulp merged commit 6ee35db into celestiaorg:master Jun 28, 2023
@rootulp rootulp deleted the rp/test-names branch June 28, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming of test cases is confusing
3 participants